fix(call): ignore stale roomJoined events that fire before joinRoomndCall#6045
fix(call): ignore stale roomJoined events that fire before joinRoomndCall#6045tareko wants to merge 1 commit intonextcloud:masterfrom
Conversation
…dCall When the app launches and immediately joins an existing call, the WebSocket may already be connected from a previous session. The server sends a stale roomJoined event before joinRoomAndCall() is called, causing performCall() to fire prematurely. Later when joinRoomAndCall runs, the WebSocket does a local join and the server never re-sends the participant list. The call stays stuck in JOINED and never transitions to IN_CONVERSATION. Add joinRoomInitiated flag to guard the roomJoined handler against stale events. Only process roomJoined after joinRoomAndCall has been called. Signed-off-by: Tarek Loubani <tarek@tarek.org>
tareko
force-pushed
the
fix-call-already-in-progress
branch
from
e0e1c7d to
261d20b
Compare
|
Hi @tareko |
|
@tareko are you interested to be invited to the nextcloud.com instance as a guest so we could also chat and you can further connect to the community? Should i invite you via tarek@tarek.org ? Also, do you like to have advanced access to the talk repo? Then you could create PR's inside it instead in your fork, which will simplify the review process |
|
Review is planned for this week |
Thank you so much for the honour. I received the invitation and accepted. |
3 participants
When the app launches and immediately joins an existing call, the WebSocket may already be connected from a previous session. The server sends a stale roomJoined event before joinRoomAndCall() is called, causing performCall() to fire prematurely. Later when joinRoomAndCall runs, the WebSocket does a local join and the server never re-sends the participant list. The call stays stuck in JOINED and never transitions to IN_CONVERSATION.
Add joinRoomInitiated flag to guard the roomJoined handler against stale events. Only process roomJoined after joinRoomAndCall has been called.
This fixes Issue #6044 . I used OpenCode and GLM-5.1 to debug and fix this bug.
🏁 Checklist
/backport to stable-xx.x